Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 68F03200BEA for ; Tue, 27 Dec 2016 16:27:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 679BE160B31; Tue, 27 Dec 2016 15:27:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AF134160B23 for ; Tue, 27 Dec 2016 16:27:55 +0100 (CET) Received: (qmail 65742 invoked by uid 500); 27 Dec 2016 15:27:54 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 65732 invoked by uid 99); 27 Dec 2016 15:27:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Dec 2016 15:27:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 73BECC03A0 for ; Tue, 27 Dec 2016 15:27:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id b5vP8QL-Cfxh for ; Tue, 27 Dec 2016 15:27:52 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 4197D5F24E for ; Tue, 27 Dec 2016 15:27:46 +0000 (UTC) Received: (qmail 65675 invoked by uid 99); 27 Dec 2016 15:27:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Dec 2016 15:27:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5E7C5DFBE6; Tue, 27 Dec 2016 15:27:45 +0000 (UTC) From: sammcveety To: commits@beam.incubator.apache.org Reply-To: commits@beam.incubator.apache.org Message-ID: Subject: [GitHub] incubator-beam pull request #1698: [BEAM-551] Cache value in NVP.get() Content-Type: text/plain Date: Tue, 27 Dec 2016 15:27:45 +0000 (UTC) archived-at: Tue, 27 Dec 2016 15:27:56 -0000 GitHub user sammcveety opened a pull request: https://github.com/apache/incubator-beam/pull/1698 [BEAM-551] Cache value in NVP.get() My understanding is that since assignment is atomic, further concurrency handling is not needed, but I am inexpert in Java's handling of such. R: @dhalperi You can merge this pull request into a Git repository by running: $ git pull https://github.com/sammcveety/incubator-beam cache_values_in_nvp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/1698.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1698 ---- commit 1af3e078da65672ad9c9e32daa4168a409693776 Author: sammcveety Date: 2016-12-27T14:56:53Z Update ValueProvider.java commit 811397877d6053d48b8e5442f6a9cac87873b3b4 Author: Sam McVeety Date: 2016-12-27T15:10:07Z Fixup ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---