Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
From: kennknowles <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-1581-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #1581: [BEAM-1117] Port Direct runner stateful P...
Content-Type: text/plain
Date: Mon, 12 Dec 2016 21:22:23 +0000 (UTC)
archived-at: Mon, 12 Dec 2016 21:22:33 -0000

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1581

    [BEAM-1117] Port Direct runner stateful ParDo to take KeyedWorkItem

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This is based upon the required PR #1556 but adds the motivating use of key-preservation logic.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam DirectRunner-Stateful-KeyedWorkItem

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1581.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1581
    
----
commit 746a78f98615a51355a901c50c5fd4db7c504a79
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-08T19:44:48Z

    Propagate key through ParDo if DoFn is key-preserving

commit 9ae20e5b8ff0b1365a324062bce2e74799fbb68e
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-08T19:49:15Z

    Add some key-preserving to KeyedPValueTrackingVisitor

commit d4129c6405fdc17ace4defc027cc5dafd61f232c
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-08T21:28:44Z

    Move responsibility for knowing about keyedness into EvaluationContext
    
    This will allow transform evaluators to inquire about whether
    various collections are keyed.

commit d590f7436ef09520a531fb1561cbdb1f1cad94af
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-08T19:29:21Z

    Port direct runner StatefulParDo to KeyedWorkItem

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---