Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Fri, 30 Dec 2016 22:42:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13031238.1483085175000.620117.1483137778615@Atlassian.JIRA>
In-Reply-To: <JIRA.13031238.1483085175000@Atlassian.JIRA>
References: <JIRA.13031238.1483085175000@Atlassian.JIRA> <JIRA.13031238.1483085175025@arcas>
Subject: [jira] [Commented] (BEAM-1232) Fix py-sdk comments to be up-to-date
 and valid
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 30 Dec 2016 22:43:03 -0000


    [ https://issues.apache.org/jira/browse/BEAM-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15788481#comment-15788481 ] 

ASF GitHub Bot commented on BEAM-1232:
--------------------------------------

GitHub user yk5 opened a pull request:

    https://github.com/apache/beam/pull/1722

    [BEAM-1232] fixed comments to refer ptransform.expand() instead of apply()

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yk5/incubator-beam fixcomments

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1722.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1722
    
----
commit 33afbb2e59ae71cad6cbd47dba9ed980db88b113
Author: Younghee Kwon <younghee.kwon@gmail.com>
Date:   2016-12-30T22:32:58Z

    Updated ptransform.apply() to ptransform.expand() in the comments.

----


> Fix py-sdk comments to be up-to-date and valid 
> -----------------------------------------------
>
>                 Key: BEAM-1232
>                 URL: https://issues.apache.org/jira/browse/BEAM-1232
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Younghee Kwon
>            Assignee: Ahmet Altay
>            Priority: Minor
>
> Some function/class comments in sdk-py are invalid or outdated, e.g. using deprecated function names, so that needs updates.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)