Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AC138200BE8 for ; Fri, 23 Dec 2016 19:52:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AA988160B1F; Fri, 23 Dec 2016 18:52:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 01C6E160B0C for ; Fri, 23 Dec 2016 19:52:03 +0100 (CET) Received: (qmail 61257 invoked by uid 500); 23 Dec 2016 18:52:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 61248 invoked by uid 99); 23 Dec 2016 18:52:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Dec 2016 18:52:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9CCAFC16B5 for ; Fri, 23 Dec 2016 18:52:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XnJuxxlp25BK for ; Fri, 23 Dec 2016 18:52:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 446AC5F1C2 for ; Fri, 23 Dec 2016 18:51:59 +0000 (UTC) Received: (qmail 60764 invoked by uid 99); 23 Dec 2016 18:51:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Dec 2016 18:51:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 60FCC2C1F54 for ; Fri, 23 Dec 2016 18:51:58 +0000 (UTC) Date: Fri, 23 Dec 2016 18:51:58 +0000 (UTC) From: "Stas Levin (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (BEAM-1205) Auto set "enableAbandonedNodeEnforcement" in TestPipeline MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 23 Dec 2016 18:52:04 -0000 [ https://issues.apache.org/jira/browse/BEAM-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stas Levin updated BEAM-1205: ----------------------------- Description: At the moment one has to manually set {{enableAbandonedNodeEnforcement(false)}} in tests that do not run the TestPipeline, otherwise one gets an {{AbandonedNodeException}} on account of having nodes that were not run. This could probably be auto detected using the {{RunnableOnService}} and {{NeedsRunner}} annotations, the presence of which indicates a given test does indeed use a runner. Essentially we need to check if {{RunnableOnService}} / {{NeedsRunner}} are present on a given test and if so set {{enableAbandonedNodeEnforcement(true)}}, otherwise set {{enableAbandonedNodeEnforcement(false)}}. [~tgroh], [~kenn] was: At the moment one has to manually set {{enableAbandonedNodeEnforcement(false)}} in tests that do not run the TestPipeline, otherwise one gets an {{AbandonedNodeException}} on account of having nodes that were not run. This could probably be auto detected using the {{RunnableOnService}} and {{NeedsRunner}} annotations, the presence of which indicates a given test does indeed use a runner. Essentially we need to check if {{RunnableOnService}} / {{NeedsRunner}} is present on a given test and if so set {{enableAbandonedNodeEnforcement(true)}}, otherwise set {{enableAbandonedNodeEnforcement(false)}}. [~tgroh], [~kenn] > Auto set "enableAbandonedNodeEnforcement" in TestPipeline > --------------------------------------------------------- > > Key: BEAM-1205 > URL: https://issues.apache.org/jira/browse/BEAM-1205 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Stas Levin > Assignee: Stas Levin > > At the moment one has to manually set {{enableAbandonedNodeEnforcement(false)}} in tests that do not run the TestPipeline, otherwise one gets an {{AbandonedNodeException}} on account of having nodes that were not run. > This could probably be auto detected using the {{RunnableOnService}} and {{NeedsRunner}} annotations, the presence of which indicates a given test does indeed use a runner. > Essentially we need to check if {{RunnableOnService}} / {{NeedsRunner}} are present on a given test and if so set {{enableAbandonedNodeEnforcement(true)}}, otherwise set {{enableAbandonedNodeEnforcement(false)}}. > [~tgroh], [~kenn] -- This message was sent by Atlassian JIRA (v6.3.4#6332)