Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 49172200BF3 for ; Wed, 21 Dec 2016 22:57:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 47DEA160B18; Wed, 21 Dec 2016 21:57:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 93615160B26 for ; Wed, 21 Dec 2016 22:57:02 +0100 (CET) Received: (qmail 47028 invoked by uid 500); 21 Dec 2016 21:57:01 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 47019 invoked by uid 99); 21 Dec 2016 21:57:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Dec 2016 21:57:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3EB7F1AA0B0 for ; Wed, 21 Dec 2016 21:57:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id e7WhSQ0EFVmU for ; Wed, 21 Dec 2016 21:57:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A1B3D5F474 for ; Wed, 21 Dec 2016 21:56:59 +0000 (UTC) Received: (qmail 46510 invoked by uid 99); 21 Dec 2016 21:56:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Dec 2016 21:56:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9BC582C2ABC for ; Wed, 21 Dec 2016 21:56:58 +0000 (UTC) Date: Wed, 21 Dec 2016 21:56:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-1194) DataflowRunner should test a variety of valid tempLocation/stagingLocation/etc formats. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 21 Dec 2016 21:57:03 -0000 [ https://issues.apache.org/jira/browse/BEAM-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768285#comment-15768285 ] ASF GitHub Bot commented on BEAM-1194: -------------------------------------- GitHub user dhalperi reopened a pull request: https://github.com/apache/incubator-beam/pull/1671 [BEAM-1194] Add DataflowLocationIT Opening PR to test. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dhalperi/incubator-beam trailing-slash Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/1671.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1671 ---- commit 7ad2ebd8e96a469e38c156de2d2701e500c3d955 Author: Dan Halperin Date: 2016-12-21T01:56:00Z Add DataflowLocationIT ---- > DataflowRunner should test a variety of valid tempLocation/stagingLocation/etc formats. > --------------------------------------------------------------------------------------- > > Key: BEAM-1194 > URL: https://issues.apache.org/jira/browse/BEAM-1194 > Project: Beam > Issue Type: Test > Components: runner-dataflow > Reporter: Daniel Halperin > Assignee: Daniel Halperin > Priority: Minor > > Cloud Dataflow has a minor history of small bugs related to various code paths expecting there to be or not be a trailing forward-slash in these location fields. The way that Beam's integration tests are set up, we are likely to only have one of these two cases tested (there is a single set of integration test pipeline options). > We should add a dedicated DataflowRunner integration test to handle this case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)