Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B5AF7200BFA for ; Wed, 28 Dec 2016 23:19:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B4700160B2A; Wed, 28 Dec 2016 22:19:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 092AA160B2E for ; Wed, 28 Dec 2016 23:19:01 +0100 (CET) Received: (qmail 40822 invoked by uid 500); 28 Dec 2016 22:19:01 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 40697 invoked by uid 99); 28 Dec 2016 22:19:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Dec 2016 22:19:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D1FB31A008E for ; Wed, 28 Dec 2016 22:19:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id nXpXLUsAYnLc for ; Wed, 28 Dec 2016 22:19:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 42C255F46D for ; Wed, 28 Dec 2016 22:18:59 +0000 (UTC) Received: (qmail 40168 invoked by uid 99); 28 Dec 2016 22:18:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Dec 2016 22:18:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 70C0A2C0059 for ; Wed, 28 Dec 2016 22:18:58 +0000 (UTC) Date: Wed, 28 Dec 2016 22:18:58 +0000 (UTC) From: "Davor Bonaci (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (BEAM-1154) ReduceFnRunner fetches side input from the wrong window MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 28 Dec 2016 22:19:02 -0000 [ https://issues.apache.org/jira/browse/BEAM-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davor Bonaci updated BEAM-1154: ------------------------------- Component/s: runner-core > ReduceFnRunner fetches side input from the wrong window > ------------------------------------------------------- > > Key: BEAM-1154 > URL: https://issues.apache.org/jira/browse/BEAM-1154 > Project: Beam > Issue Type: Bug > Components: runner-core > Reporter: Eugene Kirpichov > Assignee: Eugene Kirpichov > Fix For: 0.4.0-incubating > > > This https://github.com/apache/incubator-beam/blame/master/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnContextFactory.java#L529 is incorrect - I broke it in https://github.com/apache/incubator-beam/commit/90a0d0e13fa0332df805b79b1dc64860d9590217#diff-16edced77586e39a5f31907f4ced51b5R530 > It uses windowing strategy of the main input to do .getSideInputWindow() instead of windowing strategy of the side input. > The fix is very simple; trying to come up with a test... -- This message was sent by Atlassian JIRA (v6.3.4#6332)