Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Mon, 12 Dec 2016 20:10:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13027148.1481329795000.501934.1481573458815@Atlassian.JIRA>
In-Reply-To: <JIRA.13027148.1481329795000@Atlassian.JIRA>
References: <JIRA.13027148.1481329795000@Atlassian.JIRA> <JIRA.13027148.1481329795948@arcas>
Subject: [jira] [Commented] (BEAM-1124) Python ValidateRunner Test
 test_multi_valued_singleton_side_input Break Postcommit
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 12 Dec 2016 20:11:17 -0000


    [ https://issues.apache.org/jira/browse/BEAM-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743007#comment-15743007 ] 

ASF GitHub Bot commented on BEAM-1124:
--------------------------------------

GitHub user markflyhigh reopened a pull request:

    https://github.com/apache/incubator-beam/pull/1571

    [BEAM-1124] Temporarily Ignore a ValidatesRunnerTest That Broke Postcommit

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Test failed this [postcommit build](https://builds.apache.org/view/Beam/job/beam_PostCommit_Python_Verify/853/). Want to temporarily ignore it but still run as a unit test (tested by DirectRunner) in postcommit build.
    
    [this jira](https://issues.apache.org/jira/browse/BEAM-1124) is tracking this bug.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam disable-one-validatesRunner-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1571.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1571
    
----
commit 9931c7de34dd77913c9e119f3f002c8147b76c0f
Author: Mark Liu <markliu@markliu-macbookpro.roam.corp.google.com>
Date:   2016-12-10T00:55:45Z

    [BEAM-1124] Temporarily Ignore a ValidatesRunnerTest That Broke Postcommit

commit 28d9dc5e8fecf33e61559576e9a32c1486cf89d2
Author: Mark Liu <markliu@markliu-macbookpro.roam.corp.google.com>
Date:   2016-12-10T01:35:29Z

    fixup! Better Code Style

----


> Python ValidateRunner Test test_multi_valued_singleton_side_input Break Postcommit
> ----------------------------------------------------------------------------------
>
>                 Key: BEAM-1124
>                 URL: https://issues.apache.org/jira/browse/BEAM-1124
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow, sdk-py, testing
>            Reporter: Mark Liu
>            Assignee: Ahmet Altay
>
> Python test_multi_valued_singleton_side_input test, a ValidatesRunner test that running on dataflow service, failed and broke postcommit(https://builds.apache.org/view/Beam/job/beam_PostCommit_Python_Verify/853/).
> Here is the stack trace:
> {code}
> Traceback (most recent call last):
>   File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/dataflow_test.py", line 186, in test_multi_valued_singleton_side_input
>     pipeline.run()
>   File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/pipeline.py", line 159, in run
>     return self.runner.run(self)
>   File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/runners/dataflow_runner.py", line 195, in run
>     % getattr(self, 'last_error_msg', None), self.result)
> DataflowRuntimeException: Dataflow pipeline failed:
> (99aeafa7a8dffcc7): Traceback (most recent call last):
>   File "/usr/local/lib/python2.7/dist-packages/dataflow_worker/batchworker.py", line 514, in do_work
>     work_executor.execute()
>   File "dataflow_worker/executor.py", line 892, in dataflow_worker.executor.MapTaskExecutor.execute (dataflow_worker/executor.c:24008)
>     op.start()
>   File "dataflow_worker/executor.py", line 456, in dataflow_worker.executor.DoOperation.start (dataflow_worker/executor.c:13870)
>     def start(self):
>   File "dataflow_worker/executor.py", line 483, in dataflow_worker.executor.DoOperation.start (dataflow_worker/executor.c:13685)
>     self.dofn_runner = common.DoFnRunner(
>   File "apache_beam/runners/common.py", line 89, in apache_beam.runners.common.DoFnRunner.__init__ (apache_beam/runners/common.c:3469)
>     args, kwargs, [side_input[global_window]
>   File "/usr/local/lib/python2.7/dist-packages/apache_beam/transforms/sideinputs.py", line 192, in __getitem__
>     _FilteringIterable(self._iterable, target_window), self._view_options)
>   File "/usr/local/lib/python2.7/dist-packages/apache_beam/pvalue.py", line 279, in _from_runtime_iterable
>     'PCollection with more than one element accessed as '
> ValueError: PCollection with more than one element accessed as a singleton view.
> {code}
> Worker logs in here:
> https://builds.apache.org/view/Beam/job/beam_PostCommit_Python_Verify/853/console
> In order to temporarily ignore this test in postcommit, we can comment out annotation "@attr('ValidatesRunner')" of this test. Then it will only run as a unit test (execute by DirectRunner), but not run as a ValidatesRunner test.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)