Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Thu, 1 Dec 2016 16:51:58 +0000 (UTC)
From: "Daniel Halperin (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13024646.1480560193000.414193.1480611118352@Atlassian.JIRA>
In-Reply-To: <JIRA.13024646.1480560193000@Atlassian.JIRA>
References: <JIRA.13024646.1480560193000@Atlassian.JIRA> <JIRA.13024646.1480560193474@arcas>
Subject: [jira] [Commented] (BEAM-1065) FileBasedSource: replace
 SeekableByteChannel with open(spec, startingPosition)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 01 Dec 2016 16:52:04 -0000


    [ https://issues.apache.org/jira/browse/BEAM-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712452#comment-15712452 ] 

Daniel Halperin commented on BEAM-1065:
---------------------------------------

The ability to open at a non-zero location has previously been thought to be linked to seekability. Do we think there are channels that can be opened at non-0 offsets but cannot be seeked?

> FileBasedSource: replace SeekableByteChannel with open(spec, startingPosition)
> ------------------------------------------------------------------------------
>
>                 Key: BEAM-1065
>                 URL: https://issues.apache.org/jira/browse/BEAM-1065
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Pei He
>            Assignee: Pei He
>
> FileBasedReader should be able to open the file with the Source.getStartOffset(), and then read forward to find the first input element.
> The benefits are:
> 1. It is easier to implement a ReadableByteChannel.
> 2. Dynamically splitting won't require file systems to support seeking.
> 3. Doesn't need to seek to position twice, which is what current API does.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)