Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Sun, 4 Dec 2016 09:49:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13019951.1478812943000.433303.1480844998447@Atlassian.JIRA>
In-Reply-To: <JIRA.13019951.1478812943000@Atlassian.JIRA>
References: <JIRA.13019951.1478812943000@Atlassian.JIRA> <JIRA.13019951.1478812943206@arcas>
Subject: [jira] [Commented] (BEAM-961) CountingInput could have starting
 number
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 04 Dec 2016 09:50:03 -0000


    [ https://issues.apache.org/jira/browse/BEAM-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15719664#comment-15719664 ] 

ASF GitHub Bot commented on BEAM-961:
-------------------------------------

GitHub user vladisav opened a pull request:

    https://github.com/apache/incubator-beam/pull/1505

    [BEAM-961] Add starting number to CountingInput

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vladisav/incubator-beam BEAM-961

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1505
    
----
commit cd7dcff58f9581d56795a7d70d82fbbd8939a29b
Author: Vladisav Jelisavcic <vj@apache.org>
Date:   2016-12-04T09:42:28Z

    Add starting number to CountingInput

----


> CountingInput could have starting number
> ----------------------------------------
>
>                 Key: BEAM-961
>                 URL: https://issues.apache.org/jira/browse/BEAM-961
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Vladisav Jelisavcic
>            Priority: Trivial
>              Labels: easy, newbie, starter
>
> TL;DR: Add {{startingAt}} to {{CountingInput}}.
> Right now you can have {{CountingInput.upTo(someNumber)}} but it came up in a test that if you want to have, say, one PCollection that is 1 through 10 and another that is 11 through 20 - so you know they are disjoint - then it requires some boilerplate to add 10 to every element. That boilerplate should be part of the {{CountingInput}}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)