Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Tue, 20 Dec 2016 17:27:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.12981095.1466458376000.564554.1482254878451@Atlassian.JIRA>
In-Reply-To: <JIRA.12981095.1466458376000@Atlassian.JIRA>
References: <JIRA.12981095.1466458376000@Atlassian.JIRA> <JIRA.12981095.1466458376100@arcas>
Subject: [jira] [Commented] (BEAM-362) Move shared runner functionality out
 of SDK and into runners/core-java
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 20 Dec 2016 17:28:15 -0000


    [ https://issues.apache.org/jira/browse/BEAM-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764746#comment-15764746 ] 

ASF GitHub Bot commented on BEAM-362:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1665

    [BEAM-362] Remove deprecated AggregatorFactory from SDK

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The reason this change actually adds real value is that it is the last reference to `ExecutionContext` in the SDK. After this PR, we can move all that to runners-core, which in turn starts to unblock moving `StateInternals` and `TimerInternals` to runners-core. I haven't included that here since it will require a Dataflow worker process while this will go right in.
    
    R: @lukecwik (randomly selected committer)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam AggregatorFactory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1665.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1665
    
----
commit 7484ed9903b9b41dbb47c08c2c0eb8c45d3371ac
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-16T04:13:25Z

    Remove deprecated AggregatorFactory from SDK

----


> Move shared runner functionality out of SDK and into runners/core-java
> ----------------------------------------------------------------------
>
>                 Key: BEAM-362
>                 URL: https://issues.apache.org/jira/browse/BEAM-362
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)