Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Thu, 1 Dec 2016 04:36:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.12940666.1455918860000.409355.1480567018474@Atlassian.JIRA>
In-Reply-To: <JIRA.12940666.1455918860000@Atlassian.JIRA>
References: <JIRA.12940666.1455918860000@Atlassian.JIRA> <JIRA.12940666.1455918860344@arcas>
Subject: [jira] [Commented] (BEAM-27) Add user-ready API for interacting
 with timers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 01 Dec 2016 04:37:03 -0000


    [ https://issues.apache.org/jira/browse/BEAM-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710850#comment-15710850 ] 

ASF GitHub Bot commented on BEAM-27:
------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1477

    [BEAM-27] Add timerId to TimerData

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This `timerId` is generated to be identical to historical behavior, and to be unique per time domain and timestamp.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam timerId

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1477.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1477
    
----
commit d53275d3075d1491d8718837b00093be09f93354
Author: Kenneth Knowles <klk@google.com>
Date:   2016-11-23T22:30:57Z

    Add timerId to TimerData
    
    This timerId is generated to be identical to historical behavior, and
    to be unique per time domain and timestamp.

----


> Add user-ready API for interacting with timers
> ----------------------------------------------
>
>                 Key: BEAM-27
>                 URL: https://issues.apache.org/jira/browse/BEAM-27
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> Pipeline authors will benefit from a different factorization of interaction with underlying timers. The current APIs are targeted at runner implementers.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)