beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bjchambers <...@git.apache.org>
Subject [GitHub] beam pull request #1718: [BEAM-370] Remove more `.named()` methods
Date Thu, 29 Dec 2016 23:45:53 GMT
GitHub user bjchambers opened a pull request:

    https://github.com/apache/beam/pull/1718

    [BEAM-370] Remove more `.named()` methods

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [*] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [*(] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [*] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/beam combine-named

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1718.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1718
    
----
commit 1c83b6d3830a6073579e63f499383403255067c7
Author: bchambers <bchambers@google.com>
Date:   2016-12-29T21:01:24Z

    Move name utilities from StringUtils to NameUtils

commit 698a5239f9bccc5505a52d8675010446e0fe4cde
Author: bchambers <bchambers@google.com>
Date:   2016-12-29T21:30:53Z

    squash! Add more exhaustive tests for NameUtils

commit ab5dd68cfbbef07f6cfae83ef5fd9f8429092a12
Author: bchambers <bchambers@google.com>
Date:   2016-12-29T21:42:30Z

    squash! Remove unused name fields from ParDo constructors

commit 45547612c8200ddc4ea275aca74a6902d3f8512e
Author: bchambers <bchambers@google.com>
Date:   2016-12-29T21:10:13Z

    squash! Remove .named from Combine
    
    Introduces a NameOverride interface that allows some classes to define
    custom behavior for getting the name. This is necessary for
    parameterized CombineFns to expose details about their parameter values.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message