beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yk5 <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1691: Fixed comments to make example usage to b...
Date Thu, 22 Dec 2016 22:08:29 GMT
GitHub user yk5 opened a pull request:

    https://github.com/apache/incubator-beam/pull/1691

    Fixed comments to make example usage to be conformant to python-sdk

    Hi @robertwb, I just started to work on apache-beam python sdk b/33761836, and found some
examples mismatch to the syntax, so fixing. can you please take a look?
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yk5/incubator-beam python-sdk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1691
    
----
commit c49e2f63e3c28fe7dbb0fd9887a85dd23fa6a128
Author: Younghee Kwon <younghee.kwon@gmail.com>
Date:   2016-12-22T21:57:49Z

    Fixed the example usage in pipeline.py, which was not conforming to python-sdk.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message