beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1665: [BEAM-362] Remove deprecated AggregatorFa...
Date Tue, 20 Dec 2016 17:27:49 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1665

    [BEAM-362] Remove deprecated AggregatorFactory from SDK

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The reason this change actually adds real value is that it is the last reference to `ExecutionContext`
in the SDK. After this PR, we can move all that to runners-core, which in turn starts to unblock
moving `StateInternals` and `TimerInternals` to runners-core. I haven't included that here
since it will require a Dataflow worker process while this will go right in.
    
    R: @lukecwik (randomly selected committer)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam AggregatorFactory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1665.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1665
    
----
commit 7484ed9903b9b41dbb47c08c2c0eb8c45d3371ac
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-16T04:13:25Z

    Remove deprecated AggregatorFactory from SDK

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message