beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1647: [BEAM-1089] Replace "--none--" with a mes...
Date Fri, 16 Dec 2016 22:15:46 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1647

    [BEAM-1089] Replace "--none--" with a message in Jenkins comments

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @jasonkuster (I'll grab a committer later)
    
    I believe there was some expectation that the magic value "--none--" would disable comments.
Instead, though, Jenkins is writing that exact string to our pull requests. Until we figure
out how to actually disable comments, we may as well leave informative messages.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam jenkins-messages

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1647
    
----
commit 814b029689606d9d37dd696e4599efa0646a204b
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-16T21:59:31Z

    Replace "--none--" with a message in Jenkins comments
    
    I believe there was some expectation that the magic value "--none--"
    would disable comments. Instead, though, Jenkins is writing that
    exact string to our pull requests. Until we figure out how to actually
    disable comments, we may as well leave informative messages.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message