beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1642: Delete deprecated TimerCallback
Date Fri, 16 Dec 2016 04:29:03 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1642

    Delete deprecated TimerCallback

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @tweise I missed doing this completely, because I was focused on just a couple annoying
methods. But now there really are no `@Deprecated` and `TimerCallback` is deleted.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam TimerCallback

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1642.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1642
    
----
commit 33a977a7a157f4f8dd3d2abc8facdbaa6a723143
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-16T04:26:40Z

    Delete deprecated TimerCallback

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message