beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1616: [BEAM-1149] SimpleDoFnRunner observes win...
Date Wed, 14 Dec 2016 19:35:54 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1616

    [BEAM-1149] SimpleDoFnRunner observes window if SideInputReader is nonempty

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @amitsela 
    
    This is a quick fix. There is some redundancy with `PushbackSideInputDoFnRunner`.
    
    Confirmed that the following run - which is only run on postcommit - fails on `master`
and succeeds with this PR:
    
    ```
    mvn --batch-mode --errors verify -pl runners/spark \
        -Prunnable-on-service-tests -Plocal-runnable-on-service-tests \
        -D test=ParDoTest \
        -D mdep.analyze.skip=true \
        -D failIfNoTests=false \
        -D forkCount=0 \
        -D runnableOnServicePipelineOptions='[
          "--runner=TestSparkRunner",
          "--streaming=false",
          "--enableSparkMetricSinks=false"
        ]'
    ```


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam observesWindow

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1616.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1616
    
----
commit 9fac4ac1abed954136bb4ed5b6e9c1471c2d3c3c
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-14T19:26:27Z

    SimpleDoFnRunner observes window if SideInputReader is nonempty

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message