beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From staslev <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1595: [BEAM-85,BEAM-298] Introducing TestPipeli...
Date Tue, 13 Dec 2016 17:35:44 GMT
GitHub user staslev opened a pull request:

    https://github.com/apache/incubator-beam/pull/1595

    [BEAM-85,BEAM-298] Introducing TestPipelineRule.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @tgroh, @kennknowles.
    
    Let me know what you think.
    Once this looks good we may consider changing existing `TestPipeline` usages to `TestPipelineRule`
where applicable.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/staslev/incubator-beam BEAM-85-and-298-making-TestPipeline-a-TestRule

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1595
    
----
commit 9cb41ae501fab8355241a79986a35684f7a886a1
Author: Stas Levin <staslevin@gmail.com>
Date:   2016-12-13T17:27:41Z

    Addressing BEAM-85 and BEAM-298, introducing TestPipelineRule.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message