beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bjchambers <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1566: Add missing @Test annotation to DirectRun...
Date Fri, 09 Dec 2016 22:14:29 GMT
GitHub user bjchambers opened a pull request:

    https://github.com/apache/incubator-beam/pull/1566

    Add missing @Test annotation to DirectRunnerTest

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [*] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [*] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [*] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/incubator-beam metrics-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1566.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1566
    
----
commit d7533228f28fc6535a3c76aefe4d2e3eea9a253f
Author: bchambers <bchambers@google.com>
Date:   2016-12-09T22:05:30Z

    Add missing @Test annotation to DirectRunnerTest

commit c36132e7181ed8be0ac0c123082a42497d56bf8c
Author: bchambers <bchambers@google.com>
Date:   2016-12-09T22:11:54Z

    fixup! Improve MetricMatchers mismatch description

commit 224c52fa68ca20e73b996143d6fe099e625f37c5
Author: bchambers <bchambers@google.com>
Date:   2016-12-09T22:13:46Z

    fixup! Fix test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message