beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sammcveety <>
Subject [GitHub] incubator-beam pull request #1503: [BEAM-551] Add DisplayData handling of Va...
Date Sat, 03 Dec 2016 21:22:37 GMT
GitHub user sammcveety opened a pull request:

    [BEAM-551] Add DisplayData handling of ValueProvider<String>

    R: @dhalperi 
    - An alternative would be to accept ValueProvider<T> and call T.toString() if isAccessible
    - The parameter is not marked @Nullable because the DisplayData code calls checkNotNull

You can merge this pull request into a Git repository by running:

    $ git pull sgmc/vp_displaydata

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1503
commit 9d4efdec6932e2f0f840d84734cc7dc89f614581
Author: Sam McVeety <>
Date:   2016-12-03T21:20:24Z

    [BEAM-551] Add DisplayData handling of ValueProvider<String>


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message