beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scwhittle <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1493: [BEAM-986] Deprecate TimerCallback and In...
Date Fri, 02 Dec 2016 22:04:55 GMT
GitHub user scwhittle opened a pull request:

    https://github.com/apache/incubator-beam/pull/1493

    [BEAM-986] Deprecate TimerCallback and InMemoryTimerInternals methods using it.

    Deprecate TimerCallback and InMemoryTimerInternals methods using it.
    Instead separate advancing watermarks and removing eligible timers.
    SDK changes necessary for improving ReduceFnRunner prefetching.
    
    Hi @kennknowles , can you please take a look?  This is the sdk changes separated out from
PR adding
    prefetching.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scwhittle/incubator-beam rm_timer_callback

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1493.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1493
    
----
commit 550c6b05b426714f291174323366f82d34afeab3
Author: Sam Whittle <samuelw@google.com>
Date:   2016-12-02T06:51:37Z

    Deprecate TimerCallback and InMemoryTimerInternals methods using it.
    Instead separate advancing watermarks and removing eligible timers.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message