beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1205) Auto set "enableAbandonedNodeEnforcement" in TestPipeline
Date Wed, 28 Dec 2016 13:42:58 GMT


ASF GitHub Bot commented on BEAM-1205:

GitHub user staslev opened a pull request:

    [BEAM-1205] Auto set "enableAbandonedNodeEnforcement" in TestPipeline

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @tgroh , @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-1205-auto-set-enableAbandonedNodeEnforcement-in-TestPipeline

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1706
commit d3b3a53a7c8e1d9d63488e5b39f19b346ca95808
Author: Stas Levin <>
Date:   2016-12-22T17:13:01Z

    [BEAM-1205] Auto set "enableAbandonedNodeEnforcement" in TestPipeline


> Auto set "enableAbandonedNodeEnforcement" in TestPipeline
> ---------------------------------------------------------
>                 Key: BEAM-1205
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Stas Levin
>            Assignee: Stas Levin
> At the moment one has to manually set {{enableAbandonedNodeEnforcement(false)}} in tests
that do not run the TestPipeline, otherwise one gets an {{AbandonedNodeException}} on account
of having nodes that were not run.
> This could probably be auto detected using the {{RunnableOnService}} and {{NeedsRunner}}
annotations, the presence of which indicates a given test does indeed use a runner. 
> Essentially we need to check if {{RunnableOnService}} / {{NeedsRunner}} are present on
a given test and if so set {{enableAbandonedNodeEnforcement(true)}}, otherwise set {{enableAbandonedNodeEnforcement(false)}}.
> [~tgroh], [~kenn]

This message was sent by Atlassian JIRA

View raw message