beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stas Levin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (BEAM-1205) Auto set "enableAbandonedNodeEnforcement" in TestPipeline
Date Fri, 23 Dec 2016 18:50:58 GMT

     [ https://issues.apache.org/jira/browse/BEAM-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stas Levin updated BEAM-1205:
-----------------------------
    Description: 
At the moment one has to manually set {{enableAbandonedNodeEnforcement(false)}} in tests that
do not run the TestPipeline, otherwise one gets an {{AbandonedNodeException}} on account of
having nodes that were not run.

This could probably be auto detected using the {{RunnableOnService}} and {{NeedsRunner}} annotations,
the presence of which indicates a given test does indeed use a runner. 

Essentially we need to check if {{RunnableOnService}} is present on a given test and if so
set {{enableAbandonedNodeEnforcement(true)}}, otherwise set {{enableAbandonedNodeEnforcement(false)}}.

[~tgroh], [~kenn]

  was:
At the moment one has to manually set {{enableAbandonedNodeEnforcement(false)}} in tests that
do not run the TestPipeline, otherwise one gets an {{AbandonedNodeException}} on account of
having nodes that were not run.

This could probably be auto detected using the {{RunnableOnService}} annotation, the presence
of which indicates a given test does indeed use a runner. 

Essentially we need to check if {{RunnableOnService}} is present on a given test and if so
set {{enableAbandonedNodeEnforcement(true)}}, otherwise set {{enableAbandonedNodeEnforcement(false)}}.

[~tgroh], [~kenn]


> Auto set "enableAbandonedNodeEnforcement" in TestPipeline
> ---------------------------------------------------------
>
>                 Key: BEAM-1205
>                 URL: https://issues.apache.org/jira/browse/BEAM-1205
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>
> At the moment one has to manually set {{enableAbandonedNodeEnforcement(false)}} in tests
that do not run the TestPipeline, otherwise one gets an {{AbandonedNodeException}} on account
of having nodes that were not run.
> This could probably be auto detected using the {{RunnableOnService}} and {{NeedsRunner}}
annotations, the presence of which indicates a given test does indeed use a runner. 
> Essentially we need to check if {{RunnableOnService}} is present on a given test and
if so set {{enableAbandonedNodeEnforcement(true)}}, otherwise set {{enableAbandonedNodeEnforcement(false)}}.
> [~tgroh], [~kenn]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message