beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stas Levin (JIRA)" <>
Subject [jira] [Commented] (BEAM-1205) Auto set "enableAbandonedNodeEnforcement" in TestPipeline
Date Thu, 22 Dec 2016 18:09:58 GMT


Stas Levin commented on BEAM-1205:

If we leave the current behavior as is, and only add the bit that does:

if (!sCrashingRunner || needsRunner || runnableOnService) {

We'll be at least as safe as before, and sdk tests having {{RunnableOnService}} or {{NeedsRunner}}
will not have to fiddle with {{enableAbandonedNodeEnforcement(false/true)}}.

Am I missing something?

> Auto set "enableAbandonedNodeEnforcement" in TestPipeline
> ---------------------------------------------------------
>                 Key: BEAM-1205
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Stas Levin
>            Assignee: Stas Levin
> At the moment one has to manually set {{enableAbandonedNodeEnforcement(false)}} in tests
that do not run the TestPipeline, otherwise one gets an {{AbandonedNodeException}} on account
of having nodes that were not run.
> This could probably be auto detected using the {{RunnableOnService}} annotation, the
presence of which indicates a given test does indeed use a runner. 
> Essentially we need to check if {{RunnableOnService}} is present on a given test and
if so set {{enableAbandonedNodeEnforcement(true)}}, otherwise set {{enableAbandonedNodeEnforcement(false)}}.
> [~tgroh], [~kenn]

This message was sent by Atlassian JIRA

View raw message