beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Groh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1205) Auto set "enableAbandonedNodeEnforcement" in TestPipeline
Date Thu, 22 Dec 2016 17:38:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770623#comment-15770623
] 

Thomas Groh commented on BEAM-1205:
-----------------------------------

If a user fails to include the {{DirectRunner}} on the classpath, we'll default to {{CrashingRunner}}
- if they also forget to call {{Pipeline.run()}}, the {{TestPipeline}} won't crash, nor will
the {{CrashingRunner}} - I'm not sure if this is something we want to defend against, as that
would have to be the case for all of their tests (but if they never added {{Pipeline.run()}},
the tests will all pass vacuously - which is dangerous)

> Auto set "enableAbandonedNodeEnforcement" in TestPipeline
> ---------------------------------------------------------
>
>                 Key: BEAM-1205
>                 URL: https://issues.apache.org/jira/browse/BEAM-1205
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>
> At the moment one has to manually set {{enableAbandonedNodeEnforcement(false)}} in tests
that do not run the TestPipeline, otherwise one gets an {{AbandonedNodeException}} on account
of having nodes that were not run.
> This could probably be auto detected using the {{RunnableOnService}} annotation, the
presence of which indicates a given test does indeed use a runner. 
> Essentially we need to check if {{RunnableOnService}} is present on a given test and
if so set {{enableAbandonedNodeEnforcement(true)}}, otherwise set {{enableAbandonedNodeEnforcement(false)}}.
> [~tgroh], [~kenn]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message