beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Halperin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BEAM-1190) FileBasedSource should ignore files that matched the glob but don't exist
Date Wed, 21 Dec 2016 00:33:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765675#comment-15765675
] 

Daniel Halperin edited comment on BEAM-1190 at 12/21/16 12:33 AM:
------------------------------------------------------------------

I think this is a very scary proposal for a new default behavior, and something the user should
implement on their own in pipeline construction.

Alternately, there's already a JIRA issue for giving the user a hook to run code at expansion
time in order to, e.g., autocomplete sharding templates that eventual consistency chose not
to show.


was (Author: dhalperi@google.com):
I think this is a very scary default behavior, and something the user should implement on
their own in pipeline construction.

Alternately, there's already a JIRA issue for giving the user a hook to run code at expansion
time in order to, e.g., autocomplete sharding templates that eventual consistency chose not
to show.

> FileBasedSource should ignore files that matched the glob but don't exist
> -------------------------------------------------------------------------
>
>                 Key: BEAM-1190
>                 URL: https://issues.apache.org/jira/browse/BEAM-1190
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>
> See user issue:
> http://stackoverflow.com/questions/41251741/coping-with-eventual-consistency-of-gcs-bucket-listing
> We should, after globbing the files in FileBasedSource, individually stat every file
and remove those that don't exist, to account for the possibility that glob yielded non-existing
files due to eventual consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message