beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1178) Make naming of logger objects consistent
Date Sun, 18 Dec 2016 20:03:59 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15759358#comment-15759358
] 

ASF GitHub Bot commented on BEAM-1178:
--------------------------------------

GitHub user iemejia opened a pull request:

    https://github.com/apache/incubator-beam/pull/1655

    [BEAM-1178] Make naming of logger objects consistent

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iemejia/incubator-beam BEAM-1178-logger

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1655.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1655
    
----
commit fbfea5953000bd77b07b6a1f1c7a192e24b88021
Author: Ismaël Mejía <iemejia@gmail.com>
Date:   2016-12-18T15:02:41Z

    Fix grammar error (repeated for)

commit 11ba4d3638da2859727206d8ea887298efcad34a
Author: Ismaël Mejía <iemejia@gmail.com>
Date:   2016-12-18T20:01:13Z

    [BEAM-1178] Make naming of logger objects consistent

----


> Make naming of logger objects consistent
> ----------------------------------------
>
>                 Key: BEAM-1178
>                 URL: https://issues.apache.org/jira/browse/BEAM-1178
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core, sdk-java-extensions
>    Affects Versions: 0.5.0-incubating
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: Trivial
>
> Logger objects are used in different instances in Beam, around 90% of the current classes
that use loggers use the convention name 'LOG', however there are instances that use 'logger'
and others that uses 'LOGGER', this issue is to make the logger naming consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message