beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Chambers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1169) MetricsTest matchers should loosen expectations on physical values
Date Fri, 16 Dec 2016 20:01:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755377#comment-15755377
] 

Ben Chambers commented on BEAM-1169:
------------------------------------

Alternatively, we may need the Runner to define how Metrics are matched, and the test just
sets up the "correct" values. That would allow different runners/tests to impose reasonable
restrictions.

> MetricsTest matchers should loosen expectations on physical values
> ------------------------------------------------------------------
>
>                 Key: BEAM-1169
>                 URL: https://issues.apache.org/jira/browse/BEAM-1169
>             Project: Beam
>          Issue Type: Sub-task
>          Components: beam-model, sdk-java-core, sdk-py
>            Reporter: Ben Chambers
>
> We could use `atLeast(N)` rather than `equals(N)` for the attempted values, but even
that may be false without violating the behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message