beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1139) Investigate failures in precommit - Apex & Kryo
Date Tue, 13 Dec 2016 18:39:59 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745881#comment-15745881
] 

ASF GitHub Bot commented on BEAM-1139:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1597

    [BEAM-1139] Revert Apex+Kryo PR and fix via deps

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Reverts #1586 and moves forwards with a minor dependency hack.
    
    This may break something in the Spark runner's integration tests, since the conflict is
real and this simply overrides and hopes for the best. So do not bother to review until Jenkins
confirms integration test success.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam kryo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1597.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1597
    
----
commit 49a52cdfed404407ada7fb778413cf15b4790197
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-13T17:48:25Z

    Revert 91cc606 "This closes #1586": Kryo + UBRFBS
    
    This commits merged the following commits:
    
    47cc2dc Add Tests for Kryo Serialization of URFBS
    3c2e550 Add no-arg constructor for UnboundedReadFromBoundedSource
    
    Kryo support is, in fact, not needed for UnboundedReadFromBoundedSource,
    but we have a dependency issue where the Apex runner's dependency on Kryo
    was being overridden with an older version that does not support the
    @Bind annotations.
    
    All runners and poms are independently correct except the examples pom
    which merges the dependencies from all.

commit 3c862d931ad2b2c537e36f3098ed230605ac6114
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-13T17:59:07Z

    Alphabetize and comment runners examples/java integration tests

commit 204d6d2bd1aa59d2b6ee22c53427966e9cd69bfa
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-13T18:34:47Z

    Move Apex Kryo version into global property

commit ab2d5c0fda7b87286f8e53840a40d6d2421feb33
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-13T18:37:06Z

    Fix version of Kryo in examples/java apex-runner profile

----


> Investigate failures in precommit - Apex & Kryo
> -----------------------------------------------
>
>                 Key: BEAM-1139
>                 URL: https://issues.apache.org/jira/browse/BEAM-1139
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-apex
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Minor
>
> https://builds.apache.org/view/Beam/job/beam_PreCommit_Java_MavenInstall/org.apache.beam$beam-examples-java/5775/testReport/junit/org.apache.beam.examples/WordCountIT/testE2EWordCount/
> This is not necessarily a bug in the Apex runner, but it looks like this class cannot
be serialized via Kryo while the Apex runner needs it to be. Probably the fix is to roll-forwards
a simple change to make it Kryo serializable.
> It is not clear to me the difference between this test run and others. Clearly there
is a coverage gap.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message