beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1117) Support for new Timer API in Direct runner
Date Tue, 20 Dec 2016 23:24:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765551#comment-15765551
] 

ASF GitHub Bot commented on BEAM-1117:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1669

    [BEAM-1117] Direct runner timers prereqs

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Per request, here are some commits from #1667 broken out. I am happy to trim off more,
etc, whatever is easiest for review.
    
    R: @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam DirectRunner-timers-prereqs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1669
    
----
commit f64816e0cf2e4fcc9525f40ede01c2f8e4ecf28d
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-20T04:40:11Z

    Add informative Instant formatter to BoundedWindow

commit 46c6a4f613629f09b48e3630aa344760b0ad46d4
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-20T04:40:47Z

    Use informative Instant formatter in WatermarkHold

commit 92baa418fbe53c0e7c7afc81db31fc02ab7f3915
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-20T21:57:55Z

    Add static Window.withOutputTimeFn to match build method

commit 7118c4ff85636a65431be54fa2e2f18fb52914cf
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-20T22:20:07Z

    Add UsesTestStream for use with JUnit @Category

commit f667a3e8abcd95be7a235132219c936178ab6bc8
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-08T04:18:44Z

    Allow setting timer by ID in DirectTimerInternals

commit 217e5245e59800d57aa36551fbbdb642a5b447a0
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-20T21:37:40Z

    Hold output watermark according to pending timers

----


> Support for new Timer API in Direct runner
> ------------------------------------------
>
>                 Key: BEAM-1117
>                 URL: https://issues.apache.org/jira/browse/BEAM-1117
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-direct
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message