beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1117) Support for new Timer API in Direct runner
Date Mon, 12 Dec 2016 21:22:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743184#comment-15743184
] 

ASF GitHub Bot commented on BEAM-1117:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1581

    [BEAM-1117] Port Direct runner stateful ParDo to take KeyedWorkItem

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This is based upon the required PR #1556 but adds the motivating use of key-preservation
logic.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam DirectRunner-Stateful-KeyedWorkItem

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1581.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1581
    
----
commit 746a78f98615a51355a901c50c5fd4db7c504a79
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-08T19:44:48Z

    Propagate key through ParDo if DoFn is key-preserving

commit 9ae20e5b8ff0b1365a324062bce2e74799fbb68e
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-08T19:49:15Z

    Add some key-preserving to KeyedPValueTrackingVisitor

commit d4129c6405fdc17ace4defc027cc5dafd61f232c
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-08T21:28:44Z

    Move responsibility for knowing about keyedness into EvaluationContext
    
    This will allow transform evaluators to inquire about whether
    various collections are keyed.

commit d590f7436ef09520a531fb1561cbdb1f1cad94af
Author: Kenneth Knowles <klk@google.com>
Date:   2016-12-08T19:29:21Z

    Port direct runner StatefulParDo to KeyedWorkItem

----


> Support for new Timer API in Direct runner
> ------------------------------------------
>
>                 Key: BEAM-1117
>                 URL: https://issues.apache.org/jira/browse/BEAM-1117
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-direct
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message