beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pei He (JIRA)" <>
Subject [jira] [Commented] (BEAM-1045) Windows OS compatibilities
Date Tue, 13 Dec 2016 19:59:58 GMT


Pei He commented on BEAM-1045:

Summary of Windows OS support in Java File/Path libraries.

1. File works for file scheme, asterisk in the path:
new File("file:\\\\\\C:\\")
new File("file:\\C:\\")
new File("file:C:\\")
new File("file:C:\\a*")
new File("file:\\C:\\*")
new File("file:\\\\abc\\C:\\D:")
new File("C:\\a*")

2. Path throws for file schema, asterisk in the path or in resolve():
new File("file:C:\\a*").toPath() will throw.
new File("file:C:\\").toPath().resolve("a*") will throw.

> Windows OS compatibilities
> --------------------------
>                 Key: BEAM-1045
>                 URL:
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core, sdk-java-gcp
>            Reporter: Pei He
> One known issue is "*" is not allowed in Windows OS.
> For example, Paths.get("tempDir/*") might throw when code runs in Windows OS.
> This affecting IOChannelFactory.match(String glob).
> However, since match only requires support globs in the final component of a path. (local)
FileIOChannelFactory could do things similar as GcsIOChannelFactory:
> First, list all files under the directory path (this won't contain glob, such as *).
> Then, check each returned files whether it matches glob.
> In this way, glob (*) stays within Apache Beam's code.
> From match()'s javadoc:
> """
> Glob handling is dependent on the implementation.  Implementations should
>    * all support globs in the final component of a path (eg /foo/bar/*.txt),
>    * however they are not required to support globs in the directory paths.
> """

This message was sent by Atlassian JIRA

View raw message