beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Halperin (JIRA)" <>
Subject [jira] [Commented] (BEAM-989) GcsUtil batch remove() and copy() need tests.
Date Fri, 02 Dec 2016 20:08:59 GMT


Daniel Halperin commented on BEAM-989:

There was a pretty long discussion on (and
Luke and I did some pair code review to try to figure this out) and we could not come up with
any decent ways to test anything involving {{BatchRequest}} because of the way the test classes
are structured.

Do you have specific improvements to make here?

Otherwise, suggest closing as infeasible.

> GcsUtil batch remove() and copy() need tests.
> ---------------------------------------------
>                 Key: BEAM-989
>                 URL:
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-java-gcp
>            Reporter: Pei He
>            Assignee: Pei He
> remove(), copy(), and their callbacks are not tested with executeBatches().

This message was sent by Atlassian JIRA

View raw message