beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aliaksandr Ivanou (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BEAM-941) Replace Xyz.INSTANCE throughout the SDK with either static methods or XyzFactory.default()
Date Thu, 29 Dec 2016 13:56:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15785360#comment-15785360
] 

Aliaksandr Ivanou edited comment on BEAM-941 at 12/29/16 1:56 PM:
------------------------------------------------------------------

Hi [~davor] and Thank you !

But actually, I have a question about this ticket:
I found the INSTANCE object is only in the GlobalWindow class. 
As far as I understood this ticket, the GlobalWindow.INSTANCE(and the underlying Coder.INSTANCE)
should be replaced by the corresponding static method or factory.
If the INSTANCE will be replace by the default factory method, I think this factory should
also handle the instantiation of other BoundedWindow subclasses(e.g. IntervalWindow).
Whom can I ask if the intention of this ticket is just to create a convenience method  for
GlobalWindow Singleton, or to create the factory that handles the instantiation of BoundedWindow
objects, where GlobalWindow is a default object?



was (Author: csivanou):
Hi Davor Bonaci and Thank you !

But actually, I have a question about this ticket:
I found the INSTANCE object is only in the GlobalWindow class. 
As far as I understood this ticket, the GlobalWindow.INSTANCE(and the underlying Coder.INSTANCE)
should be replaced by the corresponding static method or factory.
If the INSTANCE will be replace by the default factory method, I think this factory should
also handle the instantiation of other BoundedWindow subclasses(e.g. IntervalWindow).
Whom can I ask if the intention of this ticket is just to create a convenience method  for
GlobalWindow Singleton, or to create the factory that handles the instantiation of BoundedWindow
objects, where GlobalWindow is a default object?


> Replace Xyz.INSTANCE throughout the SDK with either static methods or XyzFactory.default()
> ------------------------------------------------------------------------------------------
>
>                 Key: BEAM-941
>                 URL: https://issues.apache.org/jira/browse/BEAM-941
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Aliaksandr Ivanou
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message