beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-651) Consider making TypedPValue.setTypeDescriptorInternal no longer Internal
Date Tue, 06 Dec 2016 16:36:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725987#comment-15725987
] 

ASF GitHub Bot commented on BEAM-651:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1516


> Consider making TypedPValue.setTypeDescriptorInternal no longer Internal
> ------------------------------------------------------------------------
>
>                 Key: BEAM-651
>                 URL: https://issues.apache.org/jira/browse/BEAM-651
>             Project: Beam
>          Issue Type: Wish
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Neelesh Srinivas Salian
>            Priority: Minor
>              Labels: easy, easyfix, starter
>             Fix For: 0.4.0-incubating
>
>
> This would give fairly pithy answers to StackOverflow questions sometimes.
> When choosing between .getOutputCoder() and .getOutputTypeDescriptor() for a transform/DoFn
we often choose the type, so the coder registry can do its thing.
> This would also give a similar choice between .setCoder(...) and .setTypeDescriptor(...).
> And anyhow we have the intention of removing our practice of the "*Internal" suffix,
so this one might be most easily solved by making it public.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message