beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-646) Get runners out of the apply()
Date Mon, 12 Dec 2016 21:43:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743239#comment-15743239
] 

ASF GitHub Bot commented on BEAM-646:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1582

    [BEAM-646] Add Parameters to finishSpecifying

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    This removes use of getProducingTransformInternal() in TypedPValue.
    
    Ensure that all nodes are finished specifying before a call to
    `Pipeline#traverseTopologically` or `PipelineRunner#run`. This ensures
    that all nodes are fully specified without requiring the `PipelineRunner`
    to do so explicitly.
    
    Use Coder Inference rather than explicitly setting Coders within
    DirectRunner overrides.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam parametered_finish_specifying

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1582.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1582
    
----
commit 05d3151de529e1db8ffe0e16ea03e4d2674b4696
Author: Thomas Groh <tgroh@google.com>
Date:   2016-12-08T22:33:36Z

    Improve Coder Inference within DirectRunner Overrides
    
    This cleans up how coders are provided for DirectRunner overrides.
    
    Ensure that coders are provided within tests that use an empty Flatten.

commit 97d81855b7dd54b0362121fe2b7d92aafb7d6594
Author: Thomas Groh <tgroh@google.com>
Date:   2016-12-08T17:09:33Z

    Add Parameters to finishSpecifying
    
    Remove the need to use getProducingTransformInternal in TypedPValue.

----


> Get runners out of the apply()
> ------------------------------
>
>                 Key: BEAM-646
>                 URL: https://issues.apache.org/jira/browse/BEAM-646
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>
> Right now, the runner intercepts calls to apply() and replaces transforms as we go. This
means that there is no "original" user graph. For portability and misc architectural benefits,
we would like to build the original graph first, and have the runner override later.
> Some runners already work in this manner, but we could integrate it more smoothly, with
more validation, via some handy APIs on e.g. the Pipeline object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message