beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-293) StreamingOptions should not extend GcpOptions
Date Tue, 06 Dec 2016 11:11:29 GMT

    [ https://issues.apache.org/jira/browse/BEAM-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724988#comment-15724988
] 

ASF GitHub Bot commented on BEAM-293:
-------------------------------------

GitHub user jbonofre opened a pull request:

    https://github.com/apache/incubator-beam/pull/1515

    [BEAM-293] StreamingOptions doesn't extend GcpOptions

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbonofre/incubator-beam BEAM-293

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1515.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1515
    
----
commit 5c57e4fda34a1f259ee27263e3b12f94761a178b
Author: Jean-Baptiste Onofré <jbonofre@apache.org>
Date:   2016-12-06T05:20:07Z

    [BEAM-293] StreamingOptions doesn't extend GcpOptions

----


> StreamingOptions should not extend GcpOptions
> ---------------------------------------------
>
>                 Key: BEAM-293
>                 URL: https://issues.apache.org/jira/browse/BEAM-293
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>              Labels: backward-incompatible
>
> Now, the SDK {{StreamingOptions}} extends {{GcpOptions}}:
> {code}
> StreamingOptions extends ApplicationNameOptions, *GcpOptions*, PipelineOptions
> {code}
> The core SDK should not depend to GCP generally speaking.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message