beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From k...@apache.org
Subject [1/2] incubator-beam git commit: SimpleDoFnRunner observes window if SideInputReader is nonempty
Date Wed, 14 Dec 2016 19:44:28 GMT
Repository: incubator-beam
Updated Branches:
  refs/heads/master fdf07318f -> 4927cc1ab


SimpleDoFnRunner observes window if SideInputReader is nonempty


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/9fac4ac1
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/9fac4ac1
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/9fac4ac1

Branch: refs/heads/master
Commit: 9fac4ac1abed954136bb4ed5b6e9c1471c2d3c3c
Parents: 5a51ace
Author: Kenneth Knowles <klk@google.com>
Authored: Wed Dec 14 11:26:27 2016 -0800
Committer: Kenneth Knowles <klk@google.com>
Committed: Wed Dec 14 11:26:27 2016 -0800

----------------------------------------------------------------------
 .../main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/9fac4ac1/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java
----------------------------------------------------------------------
diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java
b/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java
index 0d41a8d..af7f5ca 100644
--- a/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java
+++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java
@@ -114,7 +114,7 @@ public class SimpleDoFnRunner<InputT, OutputT> implements DoFnRunner<InputT,
Out
       WindowingStrategy<?, ?> windowingStrategy) {
     this.fn = fn;
     this.signature = DoFnSignatures.getSignature(fn.getClass());
-    this.observesWindow = signature.processElement().observesWindow();
+    this.observesWindow = signature.processElement().observesWindow() || !sideInputReader.isEmpty();
     this.invoker = DoFnInvokers.invokerFor(fn);
     this.outputManager = outputManager;
     this.mainOutputTag = mainOutputTag;


Mime
View raw message