Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8BAEE200BB3 for ; Wed, 2 Nov 2016 23:53:41 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8A577160B0A; Wed, 2 Nov 2016 22:53:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D89A7160AF0 for ; Wed, 2 Nov 2016 23:53:40 +0100 (CET) Received: (qmail 77172 invoked by uid 500); 2 Nov 2016 22:53:40 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 77154 invoked by uid 99); 2 Nov 2016 22:53:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 22:53:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AC1F718030C for ; Wed, 2 Nov 2016 22:53:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id EgM8Gm7v15-S for ; Wed, 2 Nov 2016 22:53:39 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 94F9C5F24F for ; Wed, 2 Nov 2016 22:53:38 +0000 (UTC) Received: (qmail 77140 invoked by uid 99); 2 Nov 2016 22:53:38 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 22:53:38 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1735FE0FA0; Wed, 2 Nov 2016 22:53:38 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: dhalperi@apache.org To: commits@beam.incubator.apache.org Date: Wed, 02 Nov 2016 22:53:38 -0000 Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: [1/2] incubator-beam git commit: [BEAM-887] Remove false/crashing "backwards compatibility" from Sink archived-at: Wed, 02 Nov 2016 22:53:41 -0000 Repository: incubator-beam Updated Branches: refs/heads/master 522469330 -> 4dec38cee [BEAM-887] Remove false/crashing "backwards compatibility" from Sink Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/2f6104c9 Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/2f6104c9 Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/2f6104c9 Branch: refs/heads/master Commit: 2f6104c903395ac8444fcaab8830e7178ebfe050 Parents: 5224693 Author: Kenneth Knowles Authored: Wed Nov 2 11:56:43 2016 -0700 Committer: Dan Halperin Committed: Wed Nov 2 15:53:19 2016 -0700 ---------------------------------------------------------------------- sdks/java/core/src/main/java/org/apache/beam/sdk/io/Sink.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/2f6104c9/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Sink.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Sink.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Sink.java index f256c5f..d1770c8 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Sink.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Sink.java @@ -214,9 +214,7 @@ public abstract class Sink implements Serializable, HasDisplayData { /** * Returns a coder for the writer result type. */ - public Coder getWriterResultCoder() { - return null; - } + public abstract Coder getWriterResultCoder(); } /**