Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Thu, 17 Nov 2016 16:08:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13019942.1478811635000.304584.1479398938461@Atlassian.JIRA>
In-Reply-To: <JIRA.13019942.1478811635000@Atlassian.JIRA>
References: <JIRA.13019942.1478811635000@Atlassian.JIRA> <JIRA.13019942.1478811635659@arcas>
Subject: [jira] [Commented] (BEAM-959) JdbcIO validation messages need
 improvement
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 17 Nov 2016 16:09:16 -0000


    [ https://issues.apache.org/jira/browse/BEAM-959?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D156740=
88#comment-15674088 ]=20

ASF GitHub Bot commented on BEAM-959:
-------------------------------------

GitHub user jbonofre opened a pull request:

    https://github.com/apache/incubator-beam/pull/1374

    [BEAM-959] Improve validation messages in JdbcIO

    Be sure to do all of the following to help us incorporate your contribu=
tion
    quickly and easily:
   =20
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enabl=
e
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.or=
g/licenses/icla.txt).
   =20
    ---
   =20


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbonofre/incubator-beam BEAM-959

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1374
   =20
----
commit cd5336b7cd66a283ca705684d6d0217a6938d77f
Author: Jean-Baptiste Onofr=C3=A9 <jbonofre@apache.org>
Date:   2016-11-17T16:07:21Z

    [BEAM-959] Improve validation messages in JdbcIO

----


> JdbcIO validation messages need improvement
> -------------------------------------------
>
>                 Key: BEAM-959
>                 URL: https://issues.apache.org/jira/browse/BEAM-959
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-extensions
>            Reporter: Kenneth Knowles
>            Assignee: Jean-Baptiste Onofr=C3=A9
>
> The error messages upon validation of {{JdbcIO}} should be sentences that=
 explain to a user how to rectify the situation. As it is, they look like i=
nternal SDK errors.
> Here is where they are: https://github.com/apache/incubator-beam/blob/mas=
ter/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java=
#L319
> And here is how a user sees them: http://stackoverflow.com/questions/4052=
5269/jdbc-fetch-from-oracle-with-beam


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)