Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Fri, 4 Nov 2016 15:34:58 +0000 (UTC)
From: "Davor Bonaci (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13017811.1478206174000.190438.1478273698437@Atlassian.JIRA>
In-Reply-To: <JIRA.13017811.1478206174000@Atlassian.JIRA>
References: <JIRA.13017811.1478206174000@Atlassian.JIRA> <JIRA.13017811.1478206174550@arcas>
Subject: [jira] [Commented] (BEAM-896) FileBasedSink swap to temp directory
 broke Flink postcommit
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 04 Nov 2016 15:35:10 -0000


    [ https://issues.apache.org/jira/browse/BEAM-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636707#comment-15636707 ] 

Davor Bonaci commented on BEAM-896:
-----------------------------------

No worries, [~mxm] -- this was just the auto-assigned thing.

> FileBasedSink swap to temp directory broke Flink postcommit
> -----------------------------------------------------------
>
>                 Key: BEAM-896
>                 URL: https://issues.apache.org/jira/browse/BEAM-896
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink, testing
>            Reporter: Daniel Halperin
>            Assignee: Maximilian Michels
>
> The three new failures on this build https://builds.apache.org/job/beam_PostCommit_MavenVerify/1720/
> org.apache.beam.runners.flink.ReadSourceITCase.testJobWithoutObjectReuse
> org.apache.beam.runners.flink.ReadSourceITCase.testJobWithObjectReuse
> org.apache.beam.runners.flink.ReadSourceITCase.testJobCollectionExecution
> were caused by
>    Makes FileBasedSink use a temporary directory (commit: 8c1008c) (detail)
>    https://github.com/apache/incubator-beam/pull/1050
> {code}
> /tmp/org.apache.beam.runners.flink.ReadSourceITCase-result/temp-beam-part-2016-11-308_20-02-14 (Is a directory)
> java.io.FileNotFoundException: /tmp/org.apache.beam.runners.flink.ReadSourceITCase-result/temp-beam-part-2016-11-308_20-02-14 (Is a directory)
> 	at java.io.FileInputStream.open0(Native Method)
> 	at java.io.FileInputStream.open(FileInputStream.java:195)
> 	at java.io.FileInputStream.<init>(FileInputStream.java:138)
> 	at java.io.FileReader.<init>(FileReader.java:72)
> 	at org.apache.flink.test.util.TestBaseUtils.getResultReader(TestBaseUtils.java:244)
> 	at org.apache.flink.test.util.TestBaseUtils.readAllResultLines(TestBaseUtils.java:276)
> 	at org.apache.flink.test.util.TestBaseUtils.compareResultsByLinesInMemory(TestBaseUtils.java:304)
> 	at org.apache.flink.test.util.TestBaseUtils.compareResultsByLinesInMemory(TestBaseUtils.java:298)
> 	at org.apache.beam.runners.flink.ReadSourceITCase.postSubmit(ReadSourceITCase.java:58)
> 	at org.apache.flink.test.util.JavaProgramTestBase.testJobCollectionExecution(JavaProgramTestBase.java:240)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> 	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
> 	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
> 	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
> {code}
> My guess is the test is wrong here because it's reading temp files rather than final files? Or something?
> cc [~jkff] [~kirpichov] [~aljoscha] [~mxm]


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)