Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Tue, 8 Nov 2016 19:54:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13006732.1474516091000.224968.1478634898651@Atlassian.JIRA>
In-Reply-To: <JIRA.13006732.1474516091000@Atlassian.JIRA>
References: <JIRA.13006732.1474516091000@Atlassian.JIRA> <JIRA.13006732.1474516091977@arcas>
Subject: [jira] [Commented] (BEAM-664) Port Dataflow SDK WordCount
 walkthrough to Beam site
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 08 Nov 2016 19:55:03 -0000


    [ https://issues.apache.org/jira/browse/BEAM-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648620#comment-15648620 ] 

ASF GitHub Bot commented on BEAM-664:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1315

    [BEAM-664] Examples not windowed

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This PR breaks out all the non-`WindowedWordCount` examples from #1275 as their changes are much simpler and can go in immediately.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam examples-not-windowed

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1315
    
----
commit ef6033e34152ef860f2195361b915164a67c0a72
Author: Kenneth Knowles <klk@google.com>
Date:   2016-11-03T21:18:43Z

    Hardcode MinimalWordCount to the DirectRunner
    
    This makes it easy to immediately run, and removes various
    non-portable instructions and others that aren't the easiest
    for a "Getting Started" scenario.

commit 9fc73d069c35d5012b673d3932f3277dae3d1c1e
Author: Kenneth Knowles <klk@google.com>
Date:   2016-11-03T21:19:47Z

    Revise WordCount example to be better cross-runner example

commit 0996f90316478a205a220bebfb25c11a02da7873
Author: Kenneth Knowles <klk@google.com>
Date:   2016-11-03T21:50:02Z

    Revise DebuggingWordCount to be more portable

commit 64326c2e2229a8ae559715cf981ddcb89a98f80a
Author: Kenneth Knowles <klk@google.com>
Date:   2016-11-03T23:17:18Z

    Add runner-specific profiles to the examples pom.xml

----


> Port Dataflow SDK WordCount walkthrough to Beam site
> ----------------------------------------------------
>
>                 Key: BEAM-664
>                 URL: https://issues.apache.org/jira/browse/BEAM-664
>             Project: Beam
>          Issue Type: Task
>          Components: website
>            Reporter: Hadar Hod
>            Assignee: Hadar Hod
>
> Port the WordCount walkthrough from Dataflow docs to Beam website. 
> * Copy prose (translate from html to md, remove Dataflow references, etc)
> * Add accurate "How to Run" instructions for each of the WC examples
> * Include code snippets from real examples


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)