Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 58921200BC0 for ; Tue, 15 Nov 2016 13:02:21 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 57220160B03; Tue, 15 Nov 2016 12:02:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9F53D160B02 for ; Tue, 15 Nov 2016 13:02:20 +0100 (CET) Received: (qmail 23529 invoked by uid 500); 15 Nov 2016 12:02:19 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 23520 invoked by uid 99); 15 Nov 2016 12:02:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Nov 2016 12:02:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 516A4180149 for ; Tue, 15 Nov 2016 12:02:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id vwi-0Eg_EDUq for ; Tue, 15 Nov 2016 12:02:18 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 453985F47D for ; Tue, 15 Nov 2016 12:02:17 +0000 (UTC) Received: (qmail 23492 invoked by uid 99); 15 Nov 2016 12:02:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Nov 2016 12:02:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4E1C7DFE5C; Tue, 15 Nov 2016 12:02:16 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: dhalperi@apache.org To: commits@beam.incubator.apache.org Date: Tue, 15 Nov 2016 12:02:17 -0000 Message-Id: <3346f81aacc34887a64c51d420d31faf@git.apache.org> In-Reply-To: <896b10f52e724297a5b0cb0901222bc0@git.apache.org> References: <896b10f52e724297a5b0cb0901222bc0@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/2] incubator-beam git commit: [BEAM-930] Fix findbugs and re-enable Maven plugin in MongoDbIO archived-at: Tue, 15 Nov 2016 12:02:21 -0000 [BEAM-930] Fix findbugs and re-enable Maven plugin in MongoDbIO Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/7c87c662 Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/7c87c662 Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/7c87c662 Branch: refs/heads/master Commit: 7c87c662db99e581e28e3198c90d2f43a8eebe6d Parents: 2bc66f9 Author: Jean-Baptiste Onofré Authored: Mon Nov 14 16:10:53 2016 +0100 Committer: Dan Halperin Committed: Tue Nov 15 04:02:08 2016 -0800 ---------------------------------------------------------------------- sdks/java/io/mongodb/pom.xml | 13 ------------- .../java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java | 4 ++-- 2 files changed, 2 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/7c87c662/sdks/java/io/mongodb/pom.xml ---------------------------------------------------------------------- diff --git a/sdks/java/io/mongodb/pom.xml b/sdks/java/io/mongodb/pom.xml index 17dc6e7..4b100a9 100644 --- a/sdks/java/io/mongodb/pom.xml +++ b/sdks/java/io/mongodb/pom.xml @@ -31,19 +31,6 @@ IO to read and write on MongoDB. - - - - - org.codehaus.mojo - findbugs-maven-plugin - - true - - - - - org.apache.maven.plugins http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/7c87c662/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java ---------------------------------------------------------------------- diff --git a/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java b/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java index 2729602..71c017d 100644 --- a/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java +++ b/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java @@ -224,7 +224,7 @@ public class MongoDbIO { BasicDBObject stat = new BasicDBObject(); stat.append("collStats", spec.collection()); Document stats = mongoDatabase.runCommand(stat); - return Long.valueOf(stats.get("size").toString()); + return Long.parseLong(stats.get("size").toString()); } @Override @@ -456,7 +456,7 @@ public class MongoDbIO { private static class WriteFn extends DoFn { private final Write spec; - private MongoClient client; + private transient MongoClient client; private List batch; public WriteFn(Write spec) {