beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1408: [BEAM-25] Temporarily reject stateful Par...
Date Tue, 22 Nov 2016 05:40:41 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1408

    [BEAM-25] Temporarily reject stateful ParDo in FlinkRunner (until support is added)

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @aljoscha or @mxm 
    
    At present, the user-facing API for stateful `DoFn` is in the codebase but prevented from
use. It is `ParDo.of(...)` that rejects stateful `DoFn`. In #1399 I am removing this rejection,
so I need to add it to all runners until they support the API.
    
    I have also added a JUnit category so runners can exclude this from their `RunnableOnService`
test suites.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam FlinkRunner-state

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1408
    
----
commit 7de2ea30c46d076771d2759111558a01d39d8a84
Author: Kenneth Knowles <klk@google.com>
Date:   2016-11-16T05:33:28Z

    Reject stateful DoFn in FlinkRunner

commit 75744f99d5ef0cb7c0da333c2f0651ee13901e8f
Author: Kenneth Knowles <klk@google.com>
Date:   2016-11-21T23:41:13Z

    Add JUnit category for stateful ParDo tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message