beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swegner <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1401: Remove dependency on findbugs annotations...
Date Mon, 21 Nov 2016 21:12:40 GMT
GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/1401

    Remove dependency on findbugs annotations artifact

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The findbugs annotations artifact has an incompatible license and cannot
    be included within Beam. We were previously referencing it for the
    @SuppressFBWarning annotation for inline FindBugs suppression.
    
    This change moves inline suppressions out to the existing
    findbugs-filter.xml file. While not ideal as it removes the suppressions
    from the offending context, it allows us to drop our dependency on the
    incompatible artifact.
    
    We are also referencing the @Nullable attribute from findbugs. This is
    now source from findbugs jsr305, which does have a compatible license.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam findbugs-convert-suppressions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1401.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1401
    
----
commit 850fa2c0010324447e8ebf9c31ebfec4a1974db5
Author: Scott Wegner <swegner@google.com>
Date:   2016-11-21T21:07:46Z

    Remove dependency on findbugs annotations artifact
    
    The findbugs annotations artifact has an incompatible license and cannot
    be included within Beam. We were previously referencing it for the
    @SuppressFBWarning annotation for inline FindBugs suppression.
    
    This change moves inline suppressions out to the existing
    findbugs-filter.xml file. While not ideal as it removes the suppressions
    from the offending context, it allows us to drop our dependency on the
    incompatible artifact.
    
    We are also referencing the @Nullable attribute from findbugs. This is
    now source from findbugs jsr305, which does have a compatible license.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message