beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tenghuanhe <>
Subject [GitHub] incubator-beam pull request #1397: [BEAM-1020] Fix removing temporary direct...
Date Mon, 21 Nov 2016 19:44:42 GMT
GitHub user tenghuanhe opened a pull request:

    [BEAM-1020] Fix removing temporary directory bug on Windows operating system

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Failing to remove temporary directory is due to the use of wildcard * when matching all
files in the temporary directory, while Windows does not support wildcard * in the file path.
    `Collection<String> matches = factory.match(factory.resolve(tempDirectory, "*"));`
    I think It'is not very appropriate to use wildcards when removing all files in the temporary
directory because there is no matching pattern need, which may cause incompatibility problems
on Windows operating system.

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1397
commit 26fcb3a962df9d55c8b98c510177b799d4b94cf4
Author: Tenghuan He <>
Date:   2016-11-21T19:17:19Z

    Fix removing temporary directory on Windows operating system


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message