beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #1378: [BEAM-23] DirectRunner: rewrite single-ou...
Date Thu, 17 Nov 2016 19:13:10 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-23] DirectRunner: rewrite single-output ParDo to multi-output

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This is in service of simplifying the override and expansion for splittable and stateful

You can merge this pull request into a Git repository by running:

    $ git pull direct-ParDoSingleViaMulti

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1378
commit 0b7fcc8ede9d16d02d047f40f669606cbe00fc4e
Author: Kenneth Knowles <>
Date:   2016-11-17T18:14:07Z

    Separate ParDoTest cases and make them more flexible
    A number of excessively rigid name tests preclude runner expansion
    of ParDo. This change makes them into independent unit tests
    for better signal and makes them more accurate to the intent - the
    name should have the relevant information, but may have other

commit efe582f0fbd4d2693867e5d3d3b3db21de16a9fa
Author: Kenneth Knowles <>
Date:   2016-11-17T18:56:36Z

    No longer execute OldDoFnTest with DirectRunner

commit 60cb48479ee5b0b6f50100bf2f6edec3fa7a552f
Author: Kenneth Knowles <>
Date:   2016-11-16T23:43:47Z

    DirectRunner: Expand ParDo.Bound into ParDo.BoundMulti

commit abc19d5a4672aa0f1334b674c91196c77bf07641
Author: Kenneth Knowles <>
Date:   2016-11-17T19:07:32Z

    Do not override type descriptor in WithTimestamps

commit ef700c967e8589b54053bc6b5e4743f50e43ec87
Author: Kenneth Knowles <>
Date:   2016-11-17T19:08:48Z

    Use getNewFn for coder inferences in ParDo


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message