beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1377: [BEAM-999] Block earlier in BoundedReadEv...
Date Thu, 17 Nov 2016 19:12:16 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1377

    [BEAM-999] Block earlier in BoundedReadEvaluatorFactoryTest

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This ensures that the reader doesn't claim the split point, which in
    turn ensures the dynamic split request will not be refused by the
    OffsetBasedSource. If the split is refused, ...ProducesDynamicSplits
    flakes, as if the reader is faster than the split thread it can run past
    the point at which the splitter thread will attempt to split the source,
    which causes the reader to read all of the elements.
    
    Spin within TestReader#advanceImpl if the reader is being dynamically
    split, to ensure that the dynamic split fully completes before
    continuing a call to advance.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam dynamic_splitting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1377
    
----
commit bb793e3f578eadbe1d1d66e42c656a6a3f81f18f
Author: Thomas Groh <tgroh@google.com>
Date:   2016-11-17T18:56:49Z

    Block earlier in BoundedReadEvaluatorFactoryTest
    
    This ensures that the reader doesn't claim the split point, which in
    turn ensures the dynamic split request will not be refused by the
    OffsetBasedSource. If the split is refused, ...ProducesDynamicSplits
    flakes, as if the reader is faster than the split thread it can run past
    the point at which the splitter thread will attempt to split the source,
    which causes the reader to read all of the elements.
    
    Sleep within TestReader#advanceImpl if the reader is being dynamically
    split, to ensure that the dynamic split fully completes before
    continuing a call to advance.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message