beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sb2nov <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1365: Fix shared state across retry decorated f...
Date Tue, 15 Nov 2016 23:07:41 GMT
GitHub user sb2nov opened a pull request:

    https://github.com/apache/incubator-beam/pull/1365

    Fix shared state across retry decorated functions

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The fix was fairly straight forward and just needed to move the generator inside the wrapped
function.
    
    R: @aaltay @chamikaramj  PTAL

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/incubator-beam BEAM-985-fix-shared-state-in-retries

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1365
    
----
commit 5f865234dfbad47ae19a86959f92ccae7789c540
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Date:   2016-11-15T23:04:37Z

    Fix shared state across retry decorated functions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message