beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peihe <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1341: Simplify FileOperations interface by refa...
Date Thu, 10 Nov 2016 22:02:07 GMT
GitHub user peihe opened a pull request:

    https://github.com/apache/incubator-beam/pull/1341

    Simplify FileOperations interface by refactoring removeDirectoryAndFiles() into FileBasedSink.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/peihe/incubator-beam file-operations-refactor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1341.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1341
    
----
commit 29e6106d1a9c0d913770312dbaef0ab7accd5717
Author: Pei He <peihe@google.com>
Date:   2016-11-10T20:50:16Z

    Simplify FileOperations interface by refactoring removeDirectoryAndFiles() into FileBasedSink.

commit d28bd06e9972ceb05c162708431eead0c5ec40e0
Author: Pei He <peihe@google.com>
Date:   2016-11-10T21:03:38Z

    FileIOChannelFactory.match() returns empty list instead of throw.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message